Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($parse): default expressions of the form a.b to undefined #11989

Closed
wants to merge 1 commit into from

Conversation

lgalfaso
Copy link
Contributor

When there is an expression of the form a.b and there is a recursion that specifies where the value should be placed, then when a == null then set the value of the returned identifier to undefined

Closes #11959

When there is an expression of the form `a.b` and there is a recursion that
specifies where the value should be placed, then when `a == null` then set
the value of the returned identifier to `undefined`

Closes angular#11959
@lgalfaso
Copy link
Contributor Author

@petebacondarwin can you take a look at this?

@petebacondarwin
Copy link
Contributor

LGTM.

The commit message is a bit confusing though. It sounds to focused on the implementation rather than the issue that is being fixed.

How about:

fix($parse): set null reference properties to `undefined`

When there is an expression of the form `a.b` and where `a == null`, then set
the value of `a.b` to `undefined`.

Closes #11959

Or is that too general?

Other than that feel free to merge.

@petebacondarwin
Copy link
Contributor

Well done on providing such a quick fix!

@lgalfaso
Copy link
Contributor Author

lgalfaso commented Jun 1, 2015

Fixed and landed as d19504a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A problem with boolean expression evaluation in 1.4
3 participants