This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngOptions): use reference check only when not using trackBy #11996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| scope.arr[0] = {id: 10, label: 'ten'}; | ||
| }); | ||
|
|
||
| // update render due to equality watch |
|
LGTM, apart from the two comments I left. |
Change the check on changed value for ngOptions to ensure that a reference check is only done when trackBy is not used. Previously, if trackBy was being used but the values of the objects were equal a reference check was then used which would cause the check to be true if the objects had different memory references but the values were equal. This can cause issues with forms being marked dirty when the value of the model as not actually changed. Closes angular#11936
seaster
force-pushed
the
ngOptions-trackBy-Fix
branch
from
13589d1 to
746dbec
Compare
|
LGTM - feel free to merge |
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Change the check on changed value for ngOptions to ensure that a reference check is only done when trackBy is not used. Previously, if trackBy was being used but the values of the objects were equal a reference check was then used which would cause the check to be true if the objects had different memory references but the values were equal. This can cause issues with forms being marked dirty when the value of the model as not actually changed. Closes angular#11936 Closes angular#11996
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the check on changed value for ngOptions to ensure that a reference check is only done
when trackBy is not used. Previously, if trackBy was being used but the values of the objects were
equal a reference check was then used which would cause the check to be true if the objects had
different memory references but the values were equal. This can cause issues with forms being
marked dirty when the value of the model as not actually changed.
Closes #11936