docs(ngClass): add class 'has-error' to demonstrate hyphen use #12027
Conversation
Because hyphens, such as those you find in the Bootstrap theme, require special handling (quotes) when ngClass uses an object.
Added class red-error to demonstrate hyphen use
| @@ -162,7 +162,7 @@ function classDirective(name, selector) { | |||
| * @example Example that demonstrates basic bindings via ngClass directive. | |||
| <example> | |||
| <file name="index.html"> | |||
| <p ng-class="{strike: deleted, bold: important, red: error}">Map Syntax Example</p> | |||
| <p ng-class="{strike: deleted, bold: important, 'red-error': error}">Map Syntax Example</p> | |||
There was a problem hiding this comment.
This is too similar to red (and not very intuitive) :)
How about changing it to 'has-error': error.
Then you need to change the CSS class (to has-error) and also update the text on line 176 to error (apply "has-error" class).
|
@qbzzt, I left an inline comment. You can update this PR by simply pushing a new commit to your branch (the PR will be updated automatically). BTW, you can find usefull info in CONTRIBUTING.md (in case you haven't already). |
|
Thank you. I did the changes in the comment. |
|
@qbzzt, that was quick :) We are almost there. Now we have some failing e2e tests we need to fix. Anyway, you need to change |
|
Sorry, I didn't know about the tests. Anyway, they're running now but with any luck they'll succeed. |
|
Yup, they passed. (No luck, just deep knowledge and hard work :P) Thx for working on this, @qbzzt ! It LGTM. Now all we have to do is sit back and wait (hopefully it won't take long) :) |
|
It still hasn't merged. Is there a problem, or does it normally take a few days? |
|
Yes, I meant "wait for someone from the team to give it a LGTM" and then it can get merged. |
|
LGTM! For (simple) doc fixes you don't have to wait for another LGTM (unless you want to ;) |
gkalpak
changed the title
|
Merged |
|
Thank you. On Fri, Jun 5, 2015 at 6:29 PM Georgios Kalpakas notifications@github.com
|
Modify the example, to show that, when using `ngClass`'s map syntax, hyphenated classes (e.h. such as those used by Bootstrap) must be enclosed in quotes. Closes angular#12027
Sorry, I don't know how to put it in the original pull request. I'm new to GitHub. But here it is, with just one additional class, red-error, which is the only one with quotes.
Thanks,
Ori