Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($location): do not get caught in infinite digest in IE9 #12083

Closed
wants to merge 4 commits into from
Closed

fix($location): do not get caught in infinite digest in IE9 #12083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7b1a6c
fix($location): do not get caught in infinite digest in IE9
petebacondarwin Jun 11, 2015
3381fec
fix($location): do not get caught in infinite digest in IE9
petebacondarwin Jun 11, 2015
e1d9e9f
fix($location): do not get caught in infinite digest in IE9
petebacondarwin Jun 11, 2015
8f1a81e
fix($location): do not get caught in infinite digest in IE9
petebacondarwin Jun 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ng/browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ function Browser(window, document, $log, $sniffer) {
// Do the assignment again so that those two variables are referentially identical.
lastHistoryState = cachedState;
} else {
if (!sameBase) {
if (!sameBase || reloadLocation) {
reloadLocation = url;
}
if (replace) {
Expand Down
171 changes: 171 additions & 0 deletions test/ng/locationSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,27 @@ describe('$location', function() {
});
});


it('should not get caught in infinite digest when replacing path in locationChangeSuccess handler', function() {
initService({html5Mode:true,supportHistory:false});
mockUpBrowser({initialUrl:'http://server/base/home', baseHref:'/base/'});
inject(
function($browser, $location, $rootScope, $window) {
var handlerCalled = false;
$rootScope.$on('$locationChangeSuccess', function() {
handlerCalled = true;
if ($location.path() !== '/') {
$location.path('/').replace();
}
});
expect($browser.url()).toEqual('http://server/base/#/home');
$rootScope.$digest();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check that the change handler actually gets called and that the path is updated correctly

expect(handlerCalled).toEqual(true);
expect($browser.url()).toEqual('http://server/base/#/');
}
);
});

it('should not infinitely digest when using a semicolon in initial path', function() {
initService({html5Mode:true,supportHistory:true});
mockUpBrowser({initialUrl:'http://localhost:9876/;jsessionid=foo', baseHref:'/'});
Expand All @@ -672,6 +693,156 @@ describe('$location', function() {
}).not.toThrow();
});
});


function updatePathOnLocationChangeSuccessTo(newPath) {
inject(function($rootScope, $location) {
$rootScope.$on('$locationChangeSuccess', function(event, newUrl, oldUrl) {
$location.path(newPath);
});
});
}


describe('location watch for hashbang browsers', function() {

it('should not infinite $digest when going to base URL without trailing slash when $locationChangeSuccess watcher changes path to /Home', function() {
initService({html5Mode: true, supportHistory: false});
mockUpBrowser({initialUrl:'http://server/app/', baseHref:'/app/'});
inject(function($rootScope, $location, $browser) {
var $browserUrl = spyOnlyCallsWithArgs($browser, 'url').andCallThrough();

updatePathOnLocationChangeSuccessTo('/Home');

$rootScope.$digest();

expect($browser.url()).toEqual('http://server/app/#/Home');
expect($location.path()).toEqual('/Home');
expect($browserUrl.calls.length).toEqual(1);
});
});

it('should not infinite $digest when going to base URL without trailing slash when $locationChangeSuccess watcher changes path to /', function() {
initService({html5Mode: true, supportHistory: false});
mockUpBrowser({initialUrl:'http://server/app/Home', baseHref:'/app/'});
inject(function($rootScope, $location, $browser, $window) {
var $browserUrl = spyOnlyCallsWithArgs($browser, 'url').andCallThrough();

updatePathOnLocationChangeSuccessTo('/');

$rootScope.$digest();

expect($browser.url()).toEqual('http://server/app/#/');
expect($location.path()).toEqual('/');
expect($browserUrl.calls.length).toEqual(1);
expect($browserUrl.calls[0].args).toEqual(['http://server/app/#/', false, null]);
});
});

it('should not infinite $digest when going to base URL with trailing slash when $locationChangeSuccess watcher changes path to /Home', function() {
initService({html5Mode: true, supportHistory: false});
mockUpBrowser({initialUrl:'http://server/app/', baseHref:'/app/'});
inject(function($rootScope, $location, $browser) {
var $browserUrl = spyOnlyCallsWithArgs($browser, 'url').andCallThrough();

updatePathOnLocationChangeSuccessTo('/Home');
$rootScope.$digest();

expect($browser.url()).toEqual('http://server/app/#/Home');
expect($location.path()).toEqual('/Home');
expect($browserUrl.calls.length).toEqual(1);
expect($browserUrl.calls[0].args).toEqual(['http://server/app/#/Home', false, null]);
});
});

it('should not infinite $digest when going to base URL with trailing slash when $locationChangeSuccess watcher changes path to /', function() {
initService({html5Mode: true, supportHistory: false});
mockUpBrowser({initialUrl:'http://server/app/', baseHref:'/app/'});
inject(function($rootScope, $location, $browser) {
var $browserUrl = spyOnlyCallsWithArgs($browser, 'url').andCallThrough();

updatePathOnLocationChangeSuccessTo('/');
$rootScope.$digest();

expect($browser.url()).toEqual('http://server/app/#/');
expect($location.path()).toEqual('/');
expect($browserUrl.calls.length).toEqual(1);
});
});
});


describe('location watch for HTML5 browsers', function() {

it('should not infinite $digest when going to base URL without trailing slash when $locationChangeSuccess watcher changes path to /Home', function() {
initService({html5Mode: true, supportHistory: true});
mockUpBrowser({initialUrl:'http://server/app/', baseHref:'/app/'});
inject(function($rootScope, $injector, $browser) {
var $browserUrl = spyOnlyCallsWithArgs($browser, 'url').andCallThrough();

var $location = $injector.get('$location');
updatePathOnLocationChangeSuccessTo('/Home');

$rootScope.$digest();

expect($browser.url()).toEqual('http://server/app/Home');
expect($location.path()).toEqual('/Home');
expect($browserUrl.calls.length).toEqual(1);
});
});

it('should not infinite $digest when going to base URL without trailing slash when $locationChangeSuccess watcher changes path to /', function() {
initService({html5Mode: true, supportHistory: true});
mockUpBrowser({initialUrl:'http://server/app/', baseHref:'/app/'});
inject(function($rootScope, $injector, $browser) {
var $browserUrl = spyOnlyCallsWithArgs($browser, 'url').andCallThrough();

var $location = $injector.get('$location');
updatePathOnLocationChangeSuccessTo('/');

$rootScope.$digest();

expect($browser.url()).toEqual('http://server/app/');
expect($location.path()).toEqual('/');
expect($browserUrl.calls.length).toEqual(0);
});
});

it('should not infinite $digest when going to base URL with trailing slash when $locationChangeSuccess watcher changes path to /Home', function() {
initService({html5Mode: true, supportHistory: true});
mockUpBrowser({initialUrl:'http://server/app/', baseHref:'/app/'});
inject(function($rootScope, $injector, $browser) {
var $browserUrl = spyOnlyCallsWithArgs($browser, 'url').andCallThrough();

var $location = $injector.get('$location');
updatePathOnLocationChangeSuccessTo('/Home');

$rootScope.$digest();

expect($browser.url()).toEqual('http://server/app/Home');
expect($location.path()).toEqual('/Home');
expect($browserUrl.calls.length).toEqual(1);
});
});

it('should not infinite $digest when going to base URL with trailing slash when $locationChangeSuccess watcher changes path to /', function() {
initService({html5Mode: true, supportHistory: true});
mockUpBrowser({initialUrl:'http://server/app/', baseHref:'/app/'});
inject(function($rootScope, $injector, $browser) {
var $browserUrl = spyOnlyCallsWithArgs($browser, 'url').andCallThrough();

var $location = $injector.get('$location');
updatePathOnLocationChangeSuccessTo('/');

$rootScope.$digest();

expect($browser.url()).toEqual('http://server/app/');
expect($location.path()).toEqual('/');
expect($browserUrl.calls.length).toEqual(0);
});
});
});

});

describe('wiring', function() {
Expand Down