This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngTrim): allow ng-trim to work for elements input[type=radio] #12091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow elements of type input[type=radio] to specify ng-trim. Do not trim attributes values by default. BREAKING CHANGE: Attribute values are not trimmed by default Migration: when depending on attribute values to be trimmed, then manually trim them. Close: angular#11859
|
Wouldn't it be better to default to true, like it is input[type=text]? |
|
Wouldn't it be better to default to true, like it is input[type=text]?
It defaults to true
|
|
Sorry, I misread your comment. |
|
See also #5597 The title is a bit misleading, because it's a bigger change |
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
Jun 8, 2016
Allow input[type=radio] elements to specify ng-trim. Closes: angular#12091 Fixes: angular#11859
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
Jun 8, 2016
Allow input[type=radio] elements to specify ng-trim. Closes: angular#12091 Fixes: angular#11859
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
Jun 9, 2016
Allow input[type=radio] elements to specify ng-trim. Closes: angular#12091 Fixes: angular#11859
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow elements of type input[type=radio] to specify ng-trim.
Do not trim attributes values by default.
BREAKING CHANGE:
Attribute values are not trimmed
Migration: when depending on attribute values to be trimmed, then manually trim them.
DISCLAIMER: I am not too fond on not trimming attribute values by default, but put the PR here to start the discussion