Fixes to body element animation #12245

matsko · 2015-06-30T18:13:10Z

googlebot · 2015-06-30T18:13:12Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

lgalfaso · 2015-06-30T22:14:46Z

I am slightly inclined into making the new $body service an undocumented service. That a side, LGTM

Narretz · 2015-07-06T19:49:53Z

test/ngAnimate/animateSpec.js

+    inject(function($animate, $rootScope, $document, $rootElement) {
+      $animate.enabled(true);
+
+      var body = jqLite($document[0].body);


Does it make sense to use the new body service here instead?

Narretz · 2015-07-06T19:51:31Z

I also think $body should be $$body.

matsko · 2015-07-17T02:53:45Z

@petebacondarwin please review so we can merge this in tomorrow.

petebacondarwin · 2015-07-17T07:13:06Z

It looks fine to me. The only comment I have is that since $$body is only used once in the core ng module, we should move the definition of $$body over to the ngAnimate module so we don't need to make angular.js file any bigger.

This patch makes it easier to gain access to document.body via the injector.

Closes angular#11956

matsko · 2015-07-17T18:34:28Z

Merged in as 44ce9c8. Excellent work @OlenDavis.

Closes angular#11956 Closes angular#12245

googlebot added the cla: no label Jun 30, 2015

matsko force-pushed the pr_11956 branch 2 times, most recently from 11e2f11 to 0d940ad Compare June 30, 2015 18:17

Narretz reviewed Jul 6, 2015
View reviewed changes

Narretz added the component: ngAnimate label Jul 6, 2015

Narretz added this to the 1.4.2 milestone Jul 6, 2015

petebacondarwin modified the milestones: 1.4.2, 1.4.3 Jul 6, 2015

matsko force-pushed the pr_11956 branch from 0d940ad to 6e5de4b Compare July 14, 2015 00:59

petebacondarwin modified the milestones: 1.4.3, 1.4.4 Jul 16, 2015

matsko mentioned this pull request Jul 17, 2015

fix(ngAnimate): allow animations on body and root elements #11956

Closed

matsko and others added 3 commits July 17, 2015 11:11

chore(core): introduce $$body service

bc769ab

This patch makes it easier to gain access to document.body via the injector.

chore: replace jqLite($document[0].body) with $$body

81fe30b

fix(ngAnimate): allow animations on body and root elements

b4cf594

Closes angular#11956

matsko force-pushed the pr_11956 branch from 6e5de4b to b4cf594 Compare July 17, 2015 18:14

matsko closed this in 44ce9c8 Jul 17, 2015

matsko deleted the pr_11956 branch July 17, 2015 18:33

netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015

fix(ngAnimate): allow animations on body and root elements

a458ac6

Closes angular#11956 Closes angular#12245

ggershoni pushed a commit to ggershoni/angular.js that referenced this pull request Sep 29, 2015

fix(ngAnimate): allow animations on body and root elements

7de2f18

Closes angular#11956 Closes angular#12245

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes to body element animation #12245

Fixes to body element animation #12245

matsko commented Jun 30, 2015

googlebot commented Jun 30, 2015

lgalfaso commented Jun 30, 2015

Narretz Jul 6, 2015

Narretz commented Jul 6, 2015

matsko commented Jul 17, 2015

petebacondarwin commented Jul 17, 2015

matsko commented Jul 17, 2015

Fixes to body element animation #12245

Fixes to body element animation #12245

Conversation

matsko commented Jun 30, 2015

googlebot commented Jun 30, 2015

lgalfaso commented Jun 30, 2015

Narretz Jul 6, 2015

Choose a reason for hiding this comment

Narretz commented Jul 6, 2015

matsko commented Jul 17, 2015

petebacondarwin commented Jul 17, 2015

matsko commented Jul 17, 2015