Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fixed outdated link #12250

Closed
wants to merge 1 commit into from
Closed

Fixed outdated link #12250

wants to merge 1 commit into from

Conversation

Ore4444
Copy link
Contributor

@Ore4444 Ore4444 commented Jul 1, 2015

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Ore4444
Copy link
Contributor Author

Ore4444 commented Jul 1, 2015

e.g. I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jul 1, 2015
@wesleycho
Copy link
Contributor

I'm not sure linking to John Papa's style guide is necessarily the best resolution here - there are quite a few developers in the Angular community who dislike certain aspects of that style guide strongly, such as the controllerAs with vm pattern for being semantically opaque & unsearchable in a codebase of any size.

@Ore4444
Copy link
Contributor Author

Ore4444 commented Jul 2, 2015

So maybe the text title should change as well.
The current URL linked to does not have the mentioned style guide anymore, but instead itself points to John Papa's style guide.

@Narretz Narretz self-assigned this Jul 16, 2015
@Narretz Narretz closed this in d935c24 Jul 19, 2015
@Ore4444 Ore4444 deleted the patch-1 branch July 20, 2015 12:05
netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
ggershoni pushed a commit to ggershoni/angular.js that referenced this pull request Sep 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants