This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.5k
fix(merge): clone elements instead of threating them like objects #12286
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -491,6 +491,17 @@ describe('angular', function() { | |
|
||
expect(dst.date).toBe(src.date); | ||
}); | ||
|
||
it('should copy elements by reference', function() { | ||
var src = { element: document.createElement('div'), | ||
jqObject: jqLite("<p><span>s1</span><span>s2</span></p>").find("span") }; | ||
var dst = {}; | ||
|
||
extend(dst, src); | ||
|
||
expect(dst.element).toBe(src.element); | ||
expect(dst.jqObject).toBe(src.jqObject); | ||
}); | ||
}); | ||
|
||
|
||
|
@@ -570,6 +581,21 @@ describe('angular', function() { | |
expect(isDate(dst.date)).toBeTruthy(); | ||
expect(dst.date.valueOf()).toEqual(src.date.valueOf()); | ||
}); | ||
|
||
|
||
it('should copy(clone) elements', function() { | ||
var src = { element: document.createElement('div'), | ||
jqObject: jqLite("<p><span>s1</span><span>s2</span></p>").find("span") }; | ||
var dst = {}; | ||
|
||
merge(dst, src); | ||
|
||
expect(dst.element).not.toBe(src.element); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we be checking that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @petebacondarwin I think we should (it is checked on line 596). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right! |
||
expect(dst.jqObject).not.toBe(src.jqObject); | ||
|
||
expect(isElement(dst.element)).toBeTruthy(); | ||
expect(isElement(dst.jqObject)).toBeTruthy(); | ||
}); | ||
}); | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little late to the party, but shouldn't it be the other way around?
Namely:
!src[0] ? jqLite(src).clone()[0] : jqLite(src).clone();
(In fact, I would rather expect:
!src[0] ? jqLite(src).clone()[0] : src.clone();
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gadzooks you are right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkalpak - thanks for that. See 75292a6