-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(jqLite): added missing support for unbind/off with event object as parameter #12291
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Not sure what you mean by "missing support for unbind(event) and off(event)". |
Have you tested? For me they didn't work with jQlite, until I included the full jQuery lib. |
@grsmvg, yes I have tested. Good job, @gkalpak, valiantly resisting the unbeatable urge to be sarcastic about "have you tested". |
In your example you are not using the exact syntax I'm talking about ;) And glad you're not too sarcastic because we're all here to help an awesome open source project! The exact syntax that does not seem to be working is like this:
And I'm not saying it needs to be fixed, but it should at least be stated correctly in the docs imho. |
Ah, I see what you mean now :) I think it would be better phrased as "event object as parameter". I would be fine with both 😄 |
Better description
The reason someone would use this is because this looked like the only way to unbind one specific event binding without using namespaces (because namespaces are also not supported in jqlite). I've already ended up using full jQuery lib, but for future readers it's good to change this in docs. See my last commit for a better description. |
Responding to Google bot at top^^ : 'I signed it!' Pull request is ready for merge. |
CLAs look good, thanks! |
No description provided.