Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

minor fix of the $interval doc #12552

Closed
wants to merge 1 commit into from

Conversation

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@chrootsu
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@caitp
Copy link
Contributor

caitp commented Aug 11, 2015

I suppose this matches the docs for $timeout.cancel(), so lgtm --- the PR text is not super clear, though. The doc isn't saying anything about the type being undefined, it's saying the parameter is optional, and changing the type name. But it's fine.

@caitp caitp closed this in f827a8e Aug 11, 2015
@chrootsu
Copy link
Contributor Author

@caitp Thanks for the clarification )

@chrootsu chrootsu deleted the fix-interval-doc branch August 11, 2015 23:52
lee-tunnicliffe pushed a commit to lee-tunnicliffe/angular.js that referenced this pull request Aug 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants