This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngAnimate): expose a core version of $animateCss
#12570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A core version of `$animateCss` can now be injected when ngAnimate is not present. This core version doesn't trigger any animations in any way. All that it does is apply the provided from and/or to styles as well as the addClass and removeClass values. The motivation for this feature is to allow for directives to activate animations automatically when ngAnimate is included without the need to use `$animate`. Closes angular#12509
|
LGTM (from Igor in person). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A core version of
$animateCsscan now be injected whenngAnimate is not present. This core version doesn't trigger any
animations in any way. All that it does is apply the provided from
and/or to styles as well as the addClass and removeClass values.
The motivation for this feature is to allow for directives to activate
animations automatically when ngAnimate is included without the need to
use
$animate.Closes #12509