This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animateCss): the transitions options delay value should be applied before class application #12585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed before class application Applying a CSS transition delay after a reflow has hit occured where a CSS class is added/removed doesn't work. This feature does however work with keyframe animations. This patch ensures that the provided `options.delay` value is applied beforehand. Closes angular#12584
matsko
force-pushed
the
fix_animate_css_delay
branch
from
4a638d7 to
bcf3878
Compare
|
LGTM. But can you rewrite this sentence in the commit message:
It doesn't really make sense to me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying a CSS transition delay after a reflow has hit occured where a
CSS class is added/removed doesn't work. This feature does however work
with keyframe animations. This patch ensures that the provided
options.delayvalue is applied beforehand.Closes #12584