-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs: cleanup of directive animation classes #12670
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Being my first PR on this repo I'm not sure how to proceed. Do I need to fix my PR? |
I don't think the changes are quite correct. |
Do you think it would be helpful to add an examples of the classes added for each directive @Narretz? I found the docs really lacking when I was learning about ngAnimate and ended having to use the Inspector to see what classes were being added/removed. |
We had a great overview over the phases until the 1.3.x docs: https://code.angularjs.org/1.3.18/docs/api/ngAnimate/service/$animate We should get those back in.some way. |
No description provided.