Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs: cleanup of directive animation classes #12670

Closed
wants to merge 2 commits into from
Closed

docs: cleanup of directive animation classes #12670

wants to merge 2 commits into from

Conversation

brettdewoody
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@brettdewoody
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@brettdewoody brettdewoody changed the title Cleanup of directive animation classes in docs. docs: cleanup of directive animation classes Aug 25, 2015
@brettdewoody
Copy link
Author

Being my first PR on this repo I'm not sure how to proceed. Do I need to fix my PR?

@Narretz
Copy link
Contributor

Narretz commented Aug 26, 2015

I don't think the changes are quite correct. add, enter etc. don't mean the classes that are added, these are the actual events that are fired by the animation code.

@Narretz Narretz added this to the Purgatory milestone Aug 26, 2015
@brettdewoody
Copy link
Author

Do you think it would be helpful to add an examples of the classes added for each directive @Narretz?

I found the docs really lacking when I was learning about ngAnimate and ended having to use the Inspector to see what classes were being added/removed.

@Narretz
Copy link
Contributor

Narretz commented Aug 31, 2015

We had a great overview over the phases until the 1.3.x docs: https://code.angularjs.org/1.3.18/docs/api/ngAnimate/service/$animate We should get those back in.some way.

Narretz added a commit to Narretz/angular.js that referenced this pull request Jan 28, 2016
Narretz added a commit to Narretz/angular.js that referenced this pull request Jan 28, 2016
@Narretz Narretz closed this in 7de7059 Feb 8, 2016
Narretz added a commit that referenced this pull request Feb 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants