Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(CHANGELOG): Add breaking change notice for issue 12506 #12705

Closed
wants to merge 1 commit into from
Closed

docs(CHANGELOG): Add breaking change notice for issue 12506 #12705

wants to merge 1 commit into from

Conversation

lgalfaso
Copy link
Contributor

No description provided.

@lgalfaso lgalfaso force-pushed the changelog-12506 branch 2 times, most recently from 4fd143c to f513411 Compare August 30, 2015 12:01
@lgalfaso lgalfaso mentioned this pull request Aug 30, 2015
Closed
lgalfaso referenced this pull request Aug 30, 2015
@lgalfaso
perf($q): small $q performance optimization
6838c97 
Only generate a new promise when `then` receives some non-undefined parameter

Closes #12535
gkalpak
gkalpak reviewed Aug 30, 2015
View reviewed changes
CHANGELOG.md
- **$q** due to [6838c979](https://github.com/angular/angular.js/commit/6838c979451c109d959a15035177ccee715ccf19),
When writting tests, there is no need to call `$timeout.flush()` to resolve a call to `$q.when` with a value.

The previous behavior involve creating an extra promise that needed to be resolved. This is no longer needed when
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

involve --> involved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@IgorMinar
Copy link
Contributor

hmm... we didn't realize that this would break tests when we merged the original PR.

I think it's too late to revert the breaking commit, so this PR lgtm.

@petebacondarwin do you agree?

@lgalfaso
Copy link
Contributor Author

lgalfaso commented Sep 1, 2015

hmm... we didn't realize that this would break tests when we merged the
original PR.

Keep in mind that this is only for test that create a promise using when
using a value and then doing nothing (not calling then nor using it to
resolve other promise)

@IgorMinar
Copy link
Contributor

yes, I understand. still we should avoid any breaking changes in stable
releases in the future.

On Tue, Sep 1, 2015 at 12:03 PM Lucas Mirelmann notifications@github.com
wrote:

hmm... we didn't realize that this would break tests when we merged the
original PR.

Keep in mind that this is only for test that create a promise using when
using a value and then doing nothing (not calling then nor using it to
resolve other promise)

—
Reply to this email directly or view it on GitHub
#12705 (comment).

@lgalfaso lgalfaso closed this in 67afd9d Sep 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgalfaso @IgorMinar @gkalpak @googlebot