This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(input): ignore min/max if they are empty on all input types #12785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the min/max attributes are empty (i.e. `attrs.min/max === ''`), there should be no min/max validation applied (i.e. all values should be valid wrt min/max). This works correctly for `input[number]`, but not for date input family (`input[date/datetime-local/time/week/month]`). In the case on `input[number]`, an empty string for `attrs.min/max` is translated to `undefined` for `minVal/maxVal` and a check for `isUndefined(minVal/maxVal)` ensures that no min/max validation takes place. For the data input family, an empty string for `attrs.min/max` is translated to `NaN` (by `parseDate()`), so an additional check (for `isNaN(minVal/maxVal)`) is required. Fixes angular#12363
|
Couldn't we check the emptiness inside |
|
Good point, @Narretz. Updated. |
|
LGTM after squashing the commits! |
|
Thx @Narretz ! (I just added the extra commits for "reviewability".) Squashing and merging... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the min/max attributes are empty (i.e.
attrs.min/max === ''), there should be no min/max validation applied (i.e. all values should be valid wrt min/max). This works correctly forinput[number], but not for date input family (input[date/datetime-local/time/week/month]).In the case on
input[number], an empty string forattrs.min/maxis translated toundefinedforminVal/maxValand a check forisUndefined(minVal/maxVal)ensures that no min/max validation takes place.For the data input family, an empty string for
attrs.min/maxis translated toNaN(byparseDate()), so an additional check (forisNaN(minVal/maxVal)) is required.Fixes #12363