This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(filters): ensure formatNumber observes i18n decimal separators
#12850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -214,6 +214,7 @@ function formatNumber(number, pattern, groupSep, decimalSep, fractionSize) { | |||
| if (fractionSize > 0 && number < 1) { | |||
There was a problem hiding this comment.
It's not directly related to the fix, but what happens if fractionSize is 0 ?
There was a problem hiding this comment.
Nevermind, I see what happens :)
|
LGTM |
|
Tangential, but do you know if the Number input type takes i18n into consideration? |
|
It doesn't look like the HTML5 input[number] control handles i18n at all: The value (http://www.w3.org/TR/html-markup/input.number.html#input.number.attrs.value) of the input must be a string representing a floating point number (http://www.w3.org/TR/html-markup/datatypes.html#common.data.float) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10342