This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Animation Fixes #12881
Closed
Animation Fixes #12881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on the body node to be present right at injection has caused issues with unit testing as well as some animations on the body element. Reverting this patch fixes these issues. Closes angular#12874
Prior to this fix anchoring would allow for a container to be a document node or something higher beyond the body tag. This patch makes it fall back to body incase the rootElement node exists as a parent ancestor. Closes angular#12872
| var rootBodyElement = jqLite( | ||
| // this is to avoid using something that sites outside of the body | ||
| // we also special case the doc fragement case because our unit test code | ||
| // appens the $rootElement to the body after the app has been bootstrapped |
|
Great! I am all for removing private undocumented services. Other than that LGTM |
|
Am I the only one that finds it weird when people are trying to animate multiple |
|
Landed as 240d589 I promised @petebacondarwin that I would create a test in a follow-up commit that tests against the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12874
Closes #12872