This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(injector): support arrow functions with no parenthesis #12895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 20, 2015 11:22
with arrow functions parenthesis are optional in case you have exactly one argument to the function. the previous regexp assumed function arguments are always inside parenthesis and so it didn't annotate functions like `$http => $http.get(...)` correctly
|
closing in favor of #12890 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially upgraded jscs so it will parse es6 syntax correctly, but since eventually I used eval in order to not break old browsers, it is not really needed. I think we can upgrade jscs anyway, so I'm leaving this commit as is.