Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix call angular.isUndefined in $cacheFactory doc #12899

Closed
wants to merge 1 commit into from

Conversation

idoo
Copy link
Contributor

@idoo idoo commented Sep 21, 2015

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@idoo
Copy link
Contributor Author

idoo commented Sep 21, 2015

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@Narretz
Copy link
Contributor

Narretz commented Sep 21, 2015

These functions are usually available without angular while in the main angular closure. Did you experience them being undefined?

@Narretz
Copy link
Contributor

Narretz commented Sep 21, 2015

Oh I see now it's in the docs. Never mind my comment then.

@gkalpak
Copy link
Member

gkalpak commented Sep 21, 2015

@Narretz, the code belongs to an example (in the docs), so it is needed.

@gkalpak gkalpak closed this in 9e83b83 Sep 21, 2015
@idoo
Copy link
Contributor Author

idoo commented Sep 21, 2015

@gkalpak it's not working in current version
https://docs.angularjs.org/api/ng/service/$cacheFactory

@Narretz
Copy link
Contributor

Narretz commented Sep 21, 2015

Thx @gkalpak. Would also be nice to backport this to 1.4.

@Narretz
Copy link
Contributor

Narretz commented Sep 21, 2015

@idoo You have to give Travis about 20 minutes to complete the tests etc. Only then is the site updated.

gkalpak pushed a commit that referenced this pull request Sep 21, 2015
@gkalpak
Copy link
Member

gkalpak commented Sep 21, 2015

Backported to v1.4.x as 808f984.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants