This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngOptions): skip comments when looking for option elements #12952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
force-pushed
the
fix-ngoptions-12190
branch
2 times, most recently
from
d53330b
to
35f8c9d
Compare
|
LGTM |
When the empty/blank option has a directive that transcludes, ngIf for example, a comment will be added into the select. Previously, ngOptions used this comment as the empty option, which would mess up the displayed options. Closes angular#12190
Narretz
force-pushed
the
fix-ngoptions-12190
branch
from
35f8c9d
to
7f3f3dd
Compare
|
Woohoo - look at your @Narretz "merging" PRs! |
|
Yeah, it looks nice! Too bad you cannot merge / push multiple commits at once. And thanks for the review! |
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Oct 7, 2015
When an empty option has ngIf, the compilation result is different from the extracted emptyOption, so the default way of identifying the empty option doesn't work anymore. In that case, we need to make sure that we don't identify comment nodes and options whose value is '' as valid option elements. Related angular#12952 Closes angular#12190
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this pull request
Oct 7, 2015
petebacondarwin
added a commit
that referenced
this pull request
Oct 28, 2015
petebacondarwin
added a commit
that referenced
this pull request
Oct 28, 2015
petebacondarwin
added a commit
that referenced
this pull request
Oct 28, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12190