This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($injector): Allow specifying a decorator on $injector #13103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OOC, what's the usecase ? |
|
|
||
| it('should allow for decorators to $inject', function() { | ||
| injector = createInjector(['ng', function($provide) { | ||
| $provide.value('dep', 'dependency'); |
There was a problem hiding this comment.
What's this used for ? Did you mean for the key to be 'key' or something (to show it gets overwritten).
There was a problem hiding this comment.
sorry, this is a leftover
Allows the definition of a decorator on `$injector`
lgalfaso
force-pushed
the
injector-delegate
branch
from
e6bc492 to
39b39f5
Compare
The use case is to allow something that is not defined within an angular module to be injected. This would be useful in projects like ng-upgrade that need to make two different worlds coexist |
| @@ -688,6 +688,23 @@ describe('injector', function() { | |||
| expect(log.join('; ')). | |||
| toBe('myDecoratedService:input,dependency1; myService:decInput; dec+origReturn'); | |||
| }); | |||
|
|
|||
|
|
|||
| it('should allow for decorators to $inject', function() { | |||
There was a problem hiding this comment.
$inject --> $injector (?)
I would probably change it to something like: should allow decorating $injector
|
LGTM (other than a minor nitpick in a test description :)) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the definition of a decorator on
$injector