-
Notifications
You must be signed in to change notification settings - Fork 27.5k
docs(tutorial/10 - Event Handlers): missing unit test #13152
Conversation
In the doc there stands "You also have to refactor one of your unit tests because of the addition of the `mainImageUrl` model property" but the spec was missing the test of `mainImageUrl`
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a missing test for `mainImageUrl`. There is a pull request as well for the doc: angular/angular.js#13152
There is a pull request for the phonecat app but it's failing now because of an issue on master: angular/angular-phonecat#279 |
Thanks for the PR. The way I see it, the description is accurate: You need to update the test, because the |
Thank you @Narretz, I created a pull request for the test but all the builds are failing there for some reason. I will create a new pull request later. |
You don't have to open a new PR, you can push --force to your branch and it iwll update the PR. |
The tutorial has changed quite a bit (with #14416). Thx ! |
In the doc there stands "You also have to refactor one of your unit tests because of the addition of the
mainImageUrl
model property" but the spec was missing the test of
mainImageUrl