Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

perf(merge): remove unnecessary wrapping of jqLite element #13236

Closed
wants to merge 1 commit into from
Closed

perf(merge): remove unnecessary wrapping of jqLite element #13236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Angular.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ function baseExtend(dst, objs, deep) {
} else if (src.nodeName) {
dst[key] = src.cloneNode(true);
} else if (isElement(src)) {
dst[key] = jqLite(src).clone();
dst[key] = src.clone();
} else {
if (!isObject(dst[key])) dst[key] = isArray(src) ? [] : {};
baseExtend(dst[key], [src], true);
Expand Down
8 changes: 5 additions & 3 deletions test/AngularSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,8 +639,10 @@ describe('angular', function() {


it('should copy(clone) elements', function() {
var src = { element: document.createElement('div'),
jqObject: jqLite("<p><span>s1</span><span>s2</span></p>").find("span") };
var src = {
element: document.createElement('div'),
jqObject: jqLite('<p><span>s1</span><span>s2</span></p>').find('span')
};
var dst = {};

merge(dst, src);
Expand All @@ -651,7 +653,7 @@ describe('angular', function() {
expect(isElement(dst.element)).toBeTruthy();
expect(dst.element.nodeName).toBeDefined(); // i.e it is a DOM element
expect(isElement(dst.jqObject)).toBeTruthy();
expect(dst.jqObject.nodeName).toBeUndefined(dst.jqObject); // i.e it is a jqLite/jquery object
expect(dst.jqObject.nodeName).toBeUndefined(); // i.e it is a jqLite/jQuery object
});
});

Expand Down