This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(filterFilter): allow overwriting the special $ property name
#13356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the special property name that would match against any
property was hard-coded to `$`.
With this commit, the user can specify an arbitrary property name,
by passing a 4th argument to `filterFilter()`. E.g.:
```js
var items = [{foo: 'bar'}, {baz: 'qux'}];
var expr = {'%': 'bar'};
console.log(filterFilter(items, expr, null, '%')); // [{foo: 'bar'}]
```
Fixes angular#13313
|
/cc @petebacondarwin (see #13313 (comment)) |
| @@ -59,6 +60,9 @@ | |||
| * Primitive values are converted to strings. Objects are not compared against primitives, | |||
| * unless they have a custom `toString` method (e.g. `Date` objects). | |||
| * | |||
| * @param {string=} specialKey The special property name that matches against any property. | |||
There was a problem hiding this comment.
Can we call this parameter anyPropertyKey?
|
Other than the param name, this all looks good to me. But I think we should wait for 1.5.0 to land now. |
gkalpak
force-pushed
the
feat-filterFilter-overwrite-dollar
branch
from
890b2a0 to
64f08ef
Compare
|
Updated the param name. I'm fine with waiting for |
|
Since this not a BC, should we add it to 1.5? |
Maybe I miunderstood @petebacondarwin's comment. He probably meant to merge this in a subsequent Since this is neither a BC nor a fix, I'm fine either way. |
|
I think I meant that we were about about release 1.5.0 so we should just put it in a 1.5.x release |
Narretz
pushed a commit
that referenced
this pull request
Jun 16, 2016
Previously, the special property name that would match against any
property was hard-coded to `$`.
With this commit, the user can specify an arbitrary property name,
by passing a 4th argument to `filterFilter()`. E.g.:
```js
var items = [{foo: 'bar'}, {baz: 'qux'}];
var expr = {'%': 'bar'};
console.log(filterFilter(items, expr, null, '%')); // [{foo: 'bar'}]
```
Fixes #13313
PR (#13356)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the special property name that would match against any
property was hard-coded to
$.With this commit, the user can specify an arbitrary property name,
by passing a 4th argument to
filterFilter(). E.g.:Fixes #13313