Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(tutorial/8 - More Templating): describe your change... #13452

Closed
wants to merge 1 commit into from

Conversation

sijanmilan
Copy link
Contributor

Original statement is in the past tense (as if it referring to step-7 of the tutorial). Mentioned changes however are being in the done in the step-8 which is presented in the remainder of this page. Hence, future tense :)

Original statement is in the past tense (as if it referring to step-7 of the tutorial). Mentioned changes however are being in the done in the step-8 which is presented in the remainder of this page. Hence, future tense :)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@sijanmilan
Copy link
Contributor Author

I signed it!

On Sat, 5 Dec 2015 at 12:34 googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


Reply to this email directly or view it on GitHub
#13452 (comment).

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 5, 2015
@gkalpak gkalpak closed this in 341b834 Dec 7, 2015
gkalpak pushed a commit that referenced this pull request Dec 7, 2015
The original statement is in the past tense (as if it were referring to a previous step of the
tutorial). The mentioned changes, however, are being done in this setp.

Closes #13452
@gkalpak
Copy link
Member

gkalpak commented Dec 7, 2015

Backported to v1.4.x as 43c4029.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants