This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(form): make ngForm $pristine after nested control.$setPristine() (brute force version) #13798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling $setPristine on the nested form or control, form becomes $pristine of all the nested controls are pristine Closes angular#13715
…(brute force version) When calling $setPristine on the nested form or control, form becomes $pristine of all the nested controls are pristine Closes angular#13715
|
Thanks for this @linoleum-js but I think that a better algorithm would be needed. The suggestion of a counter would work well. Do you want to try to implement that instead? |
|
@petebacondarwin I already did #13773. @gkalpak ask me to split two solutions into different PRs |
|
Thanks. It is good to cross reference these things. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling $setPristine on the nested form or control,
form becomes $pristine if all the nested controls are pristine
Closes #13715