This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
docs(tutorial): update PhoneCat tutorial to Angular 1.5, components and style guide #13834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and style guide Bring the PhoneCat tutorial up to speed with Angular 1.5. Introduce components instead of bare ngControllers. Add an additional chapter about organizing the code in feature modules and using the style guide. This also makes the guide compatible with the Angular 2 upgrade tutorial on angular.io.
|
@petebacondarwin this together with the rebased steps in angular/angular-phonecat#289 completes the update from my point of view, except for the diagram images. Hoping the source files for those are somewhere, but it should be also possible to redo them from scratch. |
|
@teropa - thanks for this. We will take a look this week and hopefully update the tutorial! |
|
Cool, let me know if you need anything. |
|
|
||
| ```html | ||
| <p>Total number of phones: {{phones.length}}</p> | ||
| <p>Total number of phones: {{ctrl.phones.length}}</p> |
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Apr 12, 2016
Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Apr 12, 2016
Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Apr 12, 2016
This is a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) angular#13834. Again, mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch of [angular-phonecat](https://github.com/angular/angular-phonecat). The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
May 24, 2016
This is a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) angular#13834. Again, mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch of [angular-phonecat](https://github.com/angular/angular-phonecat). The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223
gkalpak
added a commit
that referenced
this pull request
May 24, 2016
This is a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 * 6.2.0 -- This was inspired by (and loosely based on) #13834. Again, mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch of [angular-phonecat](https://github.com/angular/angular-phonecat). The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular-phonecat#326. Related to angular/angular-seed#341. Closes #14416
gkalpak
added a commit
that referenced
this pull request
May 24, 2016
This is a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 * 6.2.0 -- This was inspired by (and loosely based on) #13834. Again, mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch of [angular-phonecat](https://github.com/angular/angular-phonecat). The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular-phonecat#326. Related to angular/angular-seed#341. Closes #14416
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the PhoneCat tutorial up to speed with Angular 1.5 and the modern
component style. Introduce components instead of bare ngControllers from
the get-go. Add an additional chapter about organizing the code in feature modules
and using the style guide.
This also makes the guide compatible with the Angular 2 upgrade tutorial
on angular.io.
Closes #13312
Related to angular/angular-phonecat#289