This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($resource): fix parse errors on older Android WebViews #13989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error is caused by reserved keyword 'finally'. Closes angular#13989
gabrielmaldi
force-pushed
the
parse-errors-reserved-keywords
branch
from
561accd to
6a740aa
Compare
gkalpak
pushed a commit
that referenced
this pull request
Feb 10, 2016
Error is caused by reserved keyword 'finally'. Closes #13989
|
Backported to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older Android WebViews (2.3) can't handle calling methods named after reserved keywords such as
.if(),.return(),.default(),.catch(),.finally().Without this change it is impossible to run an app on an Android 2.3 device directly using Angular source code.
Bracket notation is already being used, for example in $$AnimateAsyncRunFactoryProvider.
Related: #11455, #11051, #12610