Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Angular.equals - Adding an example. #14232

Closed
wants to merge 7 commits into from

Conversation

SHAHRUKH-KHAN
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Doc Update

What is the current behavior? (You can also link to an open issue here)

No Example. - https://docs.angularjs.org/api/ng/function/angular.equals

What is the new behavior (if this is a feature change)?

Adds a example

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:

This Pull requests improves the doc by adding an example to angular.equals function.

This Pull requests improves the doc by adding a example to `angular.equals` function.
@robinj
Copy link
Contributor

robinj commented Mar 14, 2016

I think the code needs a little reformatting to make it more consistent. e.g spacing between commas and parameters and a spacing between an object and attribute names. Otherwise it's a fairly concise and good example.

@Narretz Narretz added this to the Backlog milestone Mar 14, 2016
@SHAHRUKH-KHAN
Copy link
Contributor Author

@Narretz What about this request ? Does it need any improvements ?

@Narretz Narretz self-assigned this Apr 7, 2016
@Narretz
Copy link
Contributor

Narretz commented Apr 7, 2016

Thanks, merged. There was a typo in the end (missing / in the closing example), otherwise okay. Just remember for the next time, squash all commits into one.

@Narretz Narretz closed this Apr 7, 2016
Narretz pushed a commit that referenced this pull request Apr 7, 2016
This Pull requests improves the doc by adding a example to `angular.equals` function.

Closes #14232
Narretz pushed a commit that referenced this pull request Apr 7, 2016
This Pull requests improves the doc by adding a example to `angular.equals` function.

Closes #14232
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants