This repository was archived by the owner on Apr 12, 2024. It is now read-only.
revert: "fix(ngRoute): allow ngView to be included in an asynchronously loaded template"
#14424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usly loaded template" This reverts commit 5e37b2a. Eagerly loading `$route`, could break tests, because it might request the root or default route template (something `$httpBackend` would know nothing about). It will be re-applied for `v1.6.x`, with a breaking change notice and possibly a way to disable the feature is tests. Fixes angular#14337
| @@ -26,6 +26,12 @@ ngRouteModule.directive('ngView', ngViewFillContentFactory); | |||
| * | |||
| * The enter and leave animation occur concurrently. | |||
| * | |||
| * @knownIssue If `ngView` is contained in an asynchronously loaded templated (i.e. not directly | |||
There was a problem hiding this comment.
templated
And I would list the usual use-cases instead (e.g. in an ngInclude or in a directive's templateUrl)
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix (regression).
What is the current behavior? (You can also link to an open issue here)
Eagerly loading
$route, could break tests, because it might request the root or default routetemplate (something
$httpBackendwould know nothing about).See #14337.
What is the new behavior (if this is a feature change)?
Tests don't break.
Also, this was added as a known issue in
ngViewdocs.Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
This reverts commit 5e37b2a.
It will be re-applied for
v1.6.x, with a breaking change notice and possibly a way to disablethe feature is tests.
Fixes #14337