This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($injector): add workaround for fat-arrow stringification in Chrome v50 #14495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, a similar fix might help with #14240. |
|
Add a note it's fixed in v52 and LGTM |
gkalpak
force-pushed
the
fix-injector-cope-with-Chrome-stringification-bug
branch
2 times, most recently
from
1c1b1e0 to
be55ffc
Compare
gkalpak
force-pushed
the
fix-injector-cope-with-Chrome-stringification-bug
branch
from
be55ffc to
dd4edcf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
Chrome v50 throws when trying to annotate fat-arrow functions.
See #14487.
What is the new behavior (if this is a feature change)?
Fat-arrow functions get annotated correctly.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)Other information:
Everything works correctly on v52 without the fix. Not sure about v51.
I couldn't write a test, because the problem appears only when creating a fat-arrow function directly (not through
eval()).Closes #14487