This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($compile): support omitting required controller name if same as the local name #14513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the local name
Basically, making `require: {someDir: '?^someDir'}` equivalent to `require: {someDir: '?^'}`.
| return { | ||
| restrict: 'E', | ||
| scope: {}, | ||
| require: { parent: '^', sibling: '' }, |
There was a problem hiding this comment.
Perhaps worth checking "optional" require too?
|
LGTM |
gkalpak
added a commit
that referenced
this pull request
Apr 28, 2016
…the local name
Basically, making `require: {someDir: '?^someDir'}` equivalent to `require: {someDir: '?^'}`.
Closes #14513
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
You have to explicitly specify the required controller's name, even if it's the same with the local name used to bind to the requiring controller (unlike how
scope: {...}works, for example).What is the new behavior (if this is a feature change)?
require: {someDir: '?^someDir'}can be shortened asrequire: {someDir: '?^'}.Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements