Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

The Angular Docs do not show the restrictions #14541

Merged
merged 2 commits into from
May 6, 2016
Merged

The Angular Docs do not show the restrictions #14541

merged 2 commits into from
May 6, 2016

Conversation

MichaelJGW
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Docs

What is the current behavior? (You can also link to an open issue here)

The Directive ng-require does not show the correct restrictions in the USAGE section.

What is the new behavior (if this is a feature change)?

In the USAGE section it will show up as an attribute.

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:

Added * @restrict A so it will show the correct restrictions in the docs

Added  * @restrict A so it will show the correct restrictions in the docs
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gkalpak
Copy link
Member

gkalpak commented Apr 29, 2016

Thx @ThornWinters. We still need a signed CLA in order to merge this.

@MichaelJGW
Copy link
Contributor Author

I signed it!

Sent from my iPhone

On Apr 29, 2016, at 11:38 AM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@MichaelJGW
Copy link
Contributor Author

I just got the confirmation for my CLA

Sent from my iPhone

On Apr 29, 2016, at 11:45 AM, Georgios Kalpakas notifications@github.com wrote:

Thx @ThornWinters. We still need a signed CLA in order to merge this.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

fixing Travis CI Error
@Narretz Narretz merged commit 4978a06 into angular:master May 6, 2016
Narretz pushed a commit that referenced this pull request May 6, 2016
The Angular Docs do not show the restrictions

Closes #14541
Narretz pushed a commit that referenced this pull request May 6, 2016
The Angular Docs do not show the restrictions

Closes #14541
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants