This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(select): remove workaround for Chrome bug #14705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM as long ad we have a test for the expected behavior. |
|
Difficult, as the bug doesn't present itself anymore and we changed ngOptions massively in the meantime. :< |
In the Chrome issue (https://bugs.chromium.org/p/chromium/issues/detail?id=381459) I noticed that the bug can't be reproduced in Chrome 45 and the issue was closed subsequently. I've also tested again with Chrome 51 and it still works. Related: angular#6828
Narretz
force-pushed
the
fix-select-chromehack
branch
from
cbc86ea to
88272a9
Compare
|
Ok, not 'that* difficult :> |
gkalpak
pushed a commit
to gkalpak/angular.js
that referenced
this pull request
Jun 3, 2016
In the Chrome issue (https://bugs.chromium.org/p/chromium/issues/detail?id=381459) I noticed that the bug can't be reproduced in Chrome 45 and the issue was closed subsequently. I've also tested again with Chrome 51 and it still works. Additionally, the Chrome hack was kept in the select code, but wasn't ported to the ngOptions code when the two split in 7fda214, and no regression happened. Nevertheless, a test has been added to guard against a future regression. Related: angular#6828 PR: angular#14705
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Removes a no-longer need workaround
In the Chrome issue (https://bugs.chromium.org/p/chromium/issues/detail?id=381459)
I noticed that the bug can't be reproduced in Chrome 45 and the issue was
closed subsequently. I've also tested again with Chrome 51 and it still works.
Related: #6828