This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(*): document the breaking change introduced in e1da4be #15434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - **input:** add support for binding to `input[type=range]` ([913016](https://github.com/angular/angular.js/commit/9130166767c4792c5d32d08a918fc7becf32c9a6) [#5892](https://github.com/angular/angular.js/issues/5892) [#14870](https://github.com/angular/angular.js/issues/14870)) | ||
| - **input:** | ||
| - add support for binding to `input[type=range]` ([913016](https://github.com/angular/angular.js/commit/9130166767c4792c5d32d08a918fc7becf32c9a6) [#5892](https://github.com/angular/angular.js/issues/5892) [#14870](https://github.com/angular/angular.js/issues/14870)) | ||
| - add support for `step` to `input[type=number]` ([e1da4be](https://github.com/angular/angular.js/commit/e1da4bed8e291003d485a8ad346ab80bed8ae2e3) [#10597](https://github.com/angular/angular.js/issues/10597)) |
There was a problem hiding this comment.
I think that these two 913016 and e1da4be should be features.
There was a problem hiding this comment.
They are 😃 Tricked by the shortened GitHub diff?
|
|
||
| If you want to restore the previous behavior (disabling `step` validation), but still want to be | ||
| able to use the `step` attribute, you can overwrite the built-in `step` validator by using a custom | ||
| directive. For example: |
There was a problem hiding this comment.
How about?
If you want to restore the previous behavior (use the step attribute while disabling step validation), you can overwrite ...
|
Good work @gkalpak as usual you put me to shame by being much more fastidious than me :-) |
|
Nah! We're rather taking turns at that 😃 |
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update.
What is the current behavior? (You can also link to an open issue here)
Although e1da4be introduced a breaking change, it wasn't documented as such.
What is the new behavior (if this is a feature change)?
The breaking change is documented.
Does this PR introduce a breaking change?
No.
(In a way. "Let me introduce you this breaking change. It has been around for 2 releases, but I don't think you've met.)"
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)