This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($injector): do not use inherited $inject #15538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisMondok
force-pushed
the
do-not-inherit-annotations
branch
from
3ccd819 to
fce42e0
Compare
Ensure that a function has its own $inject property, and not an inherited property, when annotating. This ensures that derived functions / classes do not get the dependencies of their super class. Fixes angular#15536
ChrisMondok
force-pushed
the
do-not-inherit-annotations
branch
from
fce42e0 to
0476083
Compare
|
How would this play with derived classes that do not define their own constructor? Wouldn't that fail as it would reject the use of the parent's dependencies? |
Closed
|
I'm closing this PR: while the issue still exists, it's pretty clear that this (at least, not exactly this), is not the solution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that a function has its own $inject property, and not an inherited
property, when annotating. This ensures that derived functions / classes do not
get the dependencies of their super class.
Fixes #15536
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
#15536
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Yes
Please check if the PR fulfills these requirements
Other information:
BREAKING CHANGE:
Prior to this PR, derived classes with no dependencies could extend base classes with dependencies, as long as the derived classes did not have constructors. As of this PR, the derived class would be seen as having no dependencies, and the base class's constructor would be called with no arguments.