This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($cacheFactory) return undefined when removing non-existent cache ent... #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,6 +70,8 @@ function $CacheFactoryProvider() { | |||
| remove: function(key) { | |||
| var lruEntry = lruHash[key]; | |||
|
|
|||
| if(!lruEntry) return; | |||
…entry Making remove behave like get() when an entry does not exist by returning undefined.
|
@jtymes looks perfect now :-) |
|
thanks a lot of the fix! for future reference:
otherwise this looks good. I'm going to fix these while merging this. if you don't have our t-shirt yet please fill out this form http://goo.gl/075Sj |
|
landed as 55d1580 |
|
Thanks for those tips and the shirt! |
|
@jtymes Thank you for contributing! I saw your comments in many other issues, always very helpful and to the point. Very much appreciated! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ry
Making remove behave like get() when an entry does not exist by returning undefined.
From #1497