This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(angular.copy): copy own non-enumerable properties #15693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuzusik
commented
Feb 8, 2017
src/Angular.js
Outdated
| @@ -941,6 +941,11 @@ function copy(source, destination, maxDepth) { | |||
| for (key in source) { | |||
| destination[key] = copyElement(source[key], maxDepth); | |||
| } | |||
| // don't use Object.getOwnPropertyNames with RegExp to avoid copying RegExp lastIndex property | |||
| } else if (source && typeof Object.getOwnPropertyNames === 'function' && !isRegExp(source)) { | |||
There was a problem hiding this comment.
Not sure if it is reasonable to do isRegExp check here as I assume it can affect performance.
Not doing this check leads to copying own non-enumerable lastIndex property of RegExp object to destination.
zuzusik
force-pushed
the
zuzusik-copy_own_non_enumerable_properties
branch
from
cda871f to
eb89e21
Compare
zuzusik
commented
Feb 8, 2017
| @@ -941,6 +941,11 @@ function copy(source, destination, maxDepth) { | |||
| for (key in source) { | |||
| destination[key] = copyElement(source[key], maxDepth); | |||
| } | |||
| // don't use Object.getOwnPropertyNames with RegExp to avoid copying RegExp lastIndex property | |||
| } else if (isObject(source) && typeof Object.getOwnPropertyNames === 'function' && !isRegExp(source)) { | |||
There was a problem hiding this comment.
Not sure if it is reasonable to do isRegExp check here as I assume it can affect performance.
Not doing this check leads to copying own non-enumerable lastIndex property of RegExp object to destination.
petebacondarwin
added
component: misc core
type: bug
type: feature
branch: 1.6.x
needs: review
severity: inconvenient
and removed
type: feature
labels
zuzusik
force-pushed
the
zuzusik-copy_own_non_enumerable_properties
branch
2 times, most recently
from
62b8543 to
a1b2bfe
Compare
copying object without own non-enumerable properties is non-consistent and can lead to bugs fixes angular#15692
zuzusik
force-pushed
the
zuzusik-copy_own_non_enumerable_properties
branch
from
a1b2bfe to
4815135
Compare
|
See #15692 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
#15692
Does this PR introduce a breaking change?
not sure if this can be called a breaking change