docs(guide/Migrating from Previous Versions): add info for 1.4 ngPatt… #15765
Conversation
…ern and pattern breaking change Introduced in commit 0e00108 Closes angular#15758
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
docs/content/guide/migration.ngdoc
Outdated
|
|
||
| Due to [0e001084](https://github.com/angular/angular.js/commit/0e001084ffff8674efad289d37cb16cc4e46b50a), | ||
| The `ngPattern` and `pattern` directives will validate the regex | ||
| against the `viewValue` of `ngModel`, i.e. the value of the model |
There was a problem hiding this comment.
You should prefix viewValue, modelValue with $ as this is how they are stored in the model
|
Can you add a note to the commit message that the content in the migration guide is taken from the commit message of 0e00108? |
…delValue with $ as this is how they are stored in the model This content being included in the migration guide is taken from the commit message of 0e00108
Breaking change was introduced in commit 0e00108. This content being included in the migration guide is taken from the commit message of commit 0e00108. Closes angular#15758 Closes angular#15765
…ern and pattern breaking change
Introduced in commit 0e00108
Closes #15758