-
Notifications
You must be signed in to change notification settings - Fork 27.5k
fix for issue #1553 #1629
fix for issue #1553 #1629
Conversation
Hi @Skivvies - LGTM. I assume you have signed the CLA? |
Thanks @petebacondarwin, glad to hear it. Re the CLA, how does that work if I'd like to remain anonymous? |
When a commit is 1) trivial and unoriginal, and 2) made by an anonymous contributor, would that contributor even have any legal claim to the IP, assuming she later decided to reveal her identity and try to prove she was the original anonymous contributor? Maybe this doesn't have to stall if the CLA isn't necessary anyway. |
How anonymous do you want to be? Perhaps you could sign the CLA, which is not a public document and then privately email Igor and let him know that you are signed up? |
@petebacondarwin Okay, signed the CLA and just emailed @IgorMinar. |
Great! On 30 November 2012 23:54, skivvies notifications@github.com wrote:
|
@Skivvies awesome work! thanks for splitting the PR into two commits. I didn't get any email from you regarding CLA, but I was able to make track you down based on github timestamps. fyi: if you used the same email address for git and CLA the connection would be much more obvious ;-) |
landed as 26adeb1 thanks! would you like a t-shirt if you don't have one already? http://goo.gl/075Sj |
Thanks @IgorMinar! I emailed the address associated with your commits in the git log, igor@angularjs.org. Should I have used another? Thanks for the quick turnaround on this one, and for the awesome work on Angular in general. Look forward to contributing more in the future! |
Fixes #1553. Includes a test demonstrating the issue.