This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(docs.angularjs.org): allow robots in partials/ but prevent inde… #16457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
force-pushed
the
chore-docs-noindex
branch
from
e44cf88 to
0323993
Compare
The sitemap.xml might also prevent the indexing, as the partials are not listed. Related to angular#16432
Narretz
force-pushed
the
chore-docs-noindex
branch
from
0323993 to
7c9f57f
Compare
gkalpak
approved these changes
Feb 15, 2018
|
Yeah I changed the commit message and pushed it twice again and cancelles these jobs. The initial one is green |
|
@Narretz In such cases I wouldn’t cancel the last job as it’s then confusing during the review. |
mgol
approved these changes
Feb 15, 2018
|
@mgol You are right, I cancelled the wrong builds - sorry |
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Feb 23, 2018
The sitemap.xml might also prevent the indexing, as the partials are not listed. Related to angular#16432 Closes angular#16457 Closes angular#16446
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xing
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: