fix(ngRoute): extract path params containing hashes and/or question marks correctly

[susisu]

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR fixes a regression introduced by 840b5f0.

What is the current behavior? (You can also link to an open issue here)
If the path ($location.path()) contains hashes and/or question marks, path params are not correctly extracted.

For example, if you set $routeProvider.when('/foo/:bar', {}) and navigate to /foo/bar%23baz, you will get $routeParams.bar === "bar", not $routeParams.bar === "bar#baz".

What is the new behavior (if this is a feature change)?
Path params are correctly extracted ($routeParams.bar === "bar#baz").

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Fix/Feature: Docs have been added/updated
• Fix/Feature: Tests have been added; existing tests pass

Other information:

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[susisu]

I signed it!

[googlebot]

CLAs look good, thanks!

[googlebot]

CLAs look good, thanks!

[gkalpak]

This PR seems to unnecessarily revert a large part of 840b5f0. Can you please only make the necessary changes and leave the rest untouched.

[susisu]

@gkalpak Thanks for your review!
The previous parseRoute and pathRegExp functions have different types of arguments (urls and paths) so I thought they should be separate.

Anyway, I fixed it!

[gkalpak]

Awesome, thx!

The previous parseRoute and pathRegExp functions have different types of arguments (urls and paths) so I thought they should be separate.

I know, but they have almost the same logic, so it makes sense to share (see #14173 (comment)).

[gkalpak]

I created #16672 which adds some refactorings on top of your commits (mainly to simplify the implementation and decouple the two slightly different usecases of ngRoute/ngMocks).
Thx for providing the main fix, @susisu 💯

[Narretz]

Merged as 510404e