Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngRepeat): missing closing backtick #17040

Merged
merged 1 commit into from
Jun 2, 2020
Merged

docs(ngRepeat): missing closing backtick #17040

merged 1 commit into from
Jun 2, 2020

Conversation

eran-nussbaum
Copy link
Contributor

@eran-nussbaum eran-nussbaum commented Jun 2, 2020

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?
no

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?
no

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thx, @eran-nussbaum 👍

@gkalpak gkalpak merged commit 59b5651 into angular:master Jun 2, 2020
@eran-nussbaum eran-nussbaum deleted the patch-1 branch June 2, 2020 11:58
@@ -332,7 +332,7 @@
* For example: `item in items | filter:x as results` will store the fragment of the repeated items as `results`, but only after
* the items have been processed through the filter.
*
* Please note that `as [variable name] is not an operator but rather a part of ngRepeat

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • micro-syntax so it can be used only after all filters (and not as operator, inside an expressions
    

@@ -332,7 +332,7 @@
* For example: `item in items | filter:x as results` will store the fragment of the repeated items as `results`, but only after
* the items have been processed through the filter.
*
* Please note that `as [variable name] is not an operator but rather a part of ngRepeat

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%%+- * Please note that `as [variable name] is not an operator but rather a part of ngRepeat-+%%

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants