Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Conversation

@Keyamoon
Copy link
Contributor

nextSibling() returns a text node. By replacing it with nextElementSibling(), issue #1730 would be fixed.

Example showing wrong behavior: http://jsbin.com/exosoz/1/edit

@pkozlowski-opensource
Copy link
Member

@Keyamoon Could you add tests, change commit message and sign CLA as described here:
http://docs.angularjs.org/misc/contribute

@petebacondarwin
Copy link
Contributor

This is a valid issue.

As @pkozlowski-opensource says, it needs unit tests to demonstrate the issue - preferably in a separate commit before the fix so that it is easy to check that the tests fail before the fix is applied.

@Keyamoon
Copy link
Contributor Author

Alright I made another pull request with separate commits: #1732

Closing this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants