This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(httpBackend) Patch for Firefox bug w/ CORS and resonse headers #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=608735 In FF getAllResponseHeaders() returns null if the request is the result of CORS. Tried to format the code so that when a FF patch is released and gains enough traction it can easily be selected and deleted. Heavily inspired by jQuery's patch for the same bug. This patch falls short of passing through custom headers but covers all of the "simple response headers" in the spec at http://www.w3.org/TR/cors/ Closes #1468
|
This looks good to me. Can you just add a note to the comment that the FF bug has been already fixed and mention which FF version contains the fix. that way we'll know when it's "safe" to drop the workaround. |
ghost
assigned
added 2 commits
February 13, 2013 12:47
Adding a note about Firefox fix version and cleaned up formatting. Closes #1468
|
@IgorMinar Updated. Added a link to this ticket in the test note as well. I'm not really clear on the Mozilla release cycle but the Bugzilla ticket says 'Target Milestone: mozilla21' which I'm assuming aligns to v21 of FF. |
|
Merged as e19b04c |
|
How about custom header with firefox ? From the changes, I only can see simple header but not custom header. Is there any other patch regarding this ? Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=608735
In FF getAllResponseHeaders() returns null if the request is the result of CORS.
Tried to format the code so that when a FF patch is released and gains enough
traction it can easily be selected and deleted. Heavily inspired by jQuery's
patch for the same bug. This patch falls short of passing through custom headers
but covers all of the "simple response headers" in the spec at
http://www.w3.org/TR/cors/
Closes #1468