feat(input.email): Input of type email support multiple attribute

[sja]

Added support for HTML5 attribute multiple to enter more than one e-mail address per input field.
The mail addresses can be seperated by comma or semicolon.

[petebacondarwin]

Hi Sebastian
Thanks for this. Have you signed the CLA?
Pete

[sja]

Yes, I did.

[petebacondarwin]

Looks good to me. I have pushed a build to the CI server: http://ci.angularjs.org/job/angular.js-pete/58/

[sja]

Sorry, but I found that just changing the input fields value did not re-validate with the new regex in the tests. But my tests have not covered the error in regex too.

[petebacondarwin]

Nice fix. Please keep checking it.

[sja]

What do you mean? Should I add tests? Or just "lean back while we integrate you stuff" and "keep working on angular.js"? ;-)

[petebacondarwin]

I can't speak for the team but I will get it looked at during the next
round of PR reviews.
Do keep fixing bugs and suggesting features!

On 24 January 2013 07:04, Sebastian Janzen notifications@github.com wrote:

What do you mean? Should I add tests? Or just "lean back while we
integrate you stuff" and "keep working on angular.js"? ;-)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1866#issuecomment-12640007.

[pkozlowski-opensource]

• Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name for cross reference)
• Feature improves existing core functionality
• API is compatible with existing Angular apis and relevant standards (if applicable)
• PR doesn't contain a breaking change
• PR contains unit tests
• PR contains e2e tests (if suitable)
• PR contains documentation update
• PR passes all tests on Travis (sanity)
• PR passes all tests on ci.angularjs.org (cross-browser compatibility)
• PR is rebased against recent master
• PR is squashed into one commit per logical change
• PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
• All changes requested in review have been implemented

[pkozlowski-opensource]

@sja there are couple of things to take care of before this PR can be merged, I've included the checklist in the comment above. For now, could you squash commits so it is easier to review and update documentation?

[sja]

Ok, I checked everything, but on testacular I get resource should not encode @ in url params FAILED (Chrome & FF). I guess this is not my fault.
I'll rebase on master later to check if this have been fixed.