Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix to #1911 #1912

Closed
wants to merge 1 commit into from
Closed

Fix to #1911 #1912

wants to merge 1 commit into from

Conversation

raftalks
Copy link

Here is the solution to issue #1911

Here is the solution to issue angular#1911
@petebacondarwin
Copy link
Contributor

Hi Raf
Thanks for submitting this PR. If you feel it needs to be merged then
there are a few things you need to have completed. See
http://docs.angularjs.org/misc/contribute

First, I would take a look at the unit tests for the input directive, since
there could well be a good reason why this test checks for === equality.
https://github.com/angular/angular.js/blob/master/test/ng/directive/inputSpec.js
If you still feel that it should be included then you need to update the
spec to explain what was wrong with the previous code, i.e how the code
should be working.
Then you need to commit changes following the commit message guidelines:
https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#
.
Finally you need to have signed the CLA:
http://code.google.com/legal/individual-cla-v1.0.html.
Closing this PR for now. Please reopen it if you want to move the PR
forward.
Pete

On 29 January 2013 15:33, Raf notifications@github.com wrote:

Here is the solution to issue #1911#1911

You can merge this Pull Request by running

git pull https://github.com/raftalks/angular.js patch-2

Or view, comment on, or merge it at:

#1912
Commit Summary

File Changes

  • M src/ng/directive/input.js (2)

Patch Links:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants