fix(jqLite): IE8 no longer replaces link text content with mailto value

[gonzaloruizdevilla]

fixes #1949

IE bug: http://webbugtrack.blogspot.com.es/2008/07/bug-140-changing-mailto-links-error-in.html

Only happens when the link has only text nodes. To prevent IE from replacing the text content, the text nodes must be detached before setting the href value and reattached afterwards.

I tried to make a unit test, but I'm not able to reproduce the bug inside the test. I tried something like:

var link = angular.element('<a href="">text</a>');
link.attr("href", "mailto:name@domain.com");
expect(link.text()).toBe("text");

but with this the test doesn't fail before applying the change.

[petebacondarwin]

Perhaps you need to trigger a reflow of the DOM by asking for the
scrollWidth or something on that node?

On 10 February 2013 12:58, Gonzalo Ruiz de Villa
notifications@github.comwrote:

fixes #1949 #1949

IE bug:
http://webbugtrack.blogspot.com.es/2008/07/bug-140-changing-mailto-links-error-in.html

Only happens when the link has only text nodes. To prevent IE from
replacing the text content, the text nodes must be detached before setting
the href value and reattached afterwards.

I tried to make a unit test, but I'm not able to reproduce the bug inside
the test. I tried something like:

var link = angular.element('text');link.attr("href", "mailto:name@domain.com");expect(link.text()).toBe("text");

but with this the test doesn't fail before applying the change.

You can merge this Pull Request by running

git pull https://github.com/gonzaloruizdevilla/angular.js issue1949

Or view, comment on, or merge it at:

#1982
Commit Summary

• fix(jqLite): IE8 no longer replaces link text content with href
  mailto value

File Changes

• M src/jqLite.jshttps://github.com/fix(jqLite): IE8 no longer replaces link text content with mailto value #1982/files#diff-0(21)

Patch Links:

• https://github.com/angular/angular.js/pull/1982.patch
• https://github.com/angular/angular.js/pull/1982.diff

[gonzaloruizdevilla]

I'm going to try that approach

Also, I've found out that the bug is not produced because of the "mailto:", but instead is reproduced when using a text like an email. "a@a" also triggers the change in the text. I have to change PR code to take this into account.

[gonzaloruizdevilla]

It turned out that the reflow trigger was not needed for the test, only a better understanding of the mysterious ways of IE8.

The fact is that IE8 replaces the content, if at least the following conditions exist:

• content has an at sign and does not end with it
• the value of "href" is like an URI or email (more or less)

This is why the code I posted in the comment didn't force the change, the link's text didn't contain an at sign.

Also, when jQuery is loaded in the page, this fix doesn't work. I will send it to jQuery too, they have a closed issue with this problem in "patchwelcome" status: http://bugs.jquery.com/ticket/8805

[IgorMinar]

thanks for the pull request. Misko and I reviewed it and found an alternative solution that is lighter and fixes the bug for jquery as well. See #2013.

Your debugging however was super helpful! Thanks :-)

[gonzaloruizdevilla]

You always find much better ways to solve the bugs than the ones I send in my PRs. :)
I greatly appreciate this, in my daily work nobody reviews my code, and it's very good for me to have this feedback and to learn better ways of doing things. Thanks to you :-)