Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($animator): skip animation for initial show/hide #2331

Closed
wants to merge 1 commit into from

Conversation

olostan
Copy link
Contributor

@olostan olostan commented Apr 8, 2013

ngShow/ngHide directivies started animation just after rendering causing
unexpected behaviour of showing animation of elements that should be already
shown. This fix allows specifing "instant" parameter for $animator.show and
$animator.hide functions to skip actual animation.

More information is at #2309

ngShow/ngHide directivies started animation just after rendering causing
unexpected behaviour of showing animation of elements that should be already
shown. This fix allows specifing "instant" parameter for $animator.show and
$animator.hide functions to skip actual animation.

More information is at angular#2309
@alexeygolev
Copy link

+1

@mhevery
Copy link
Contributor

mhevery commented Apr 11, 2013

Thanks for the commit. We have already fixed this issue in a cleaner way.

@mhevery mhevery closed this Apr 11, 2013
@lukasmlady
Copy link

Hi, is the fix commited yet? The issue is still showing up after merging with the latest version of $animator.

@mhevery
Copy link
Contributor

mhevery commented May 8, 2013

This is already checked into the master branch.

  1. animation can only run if there are no other animations running above it. This prevents animation in animation bug
  2. On initial render we create a fake parent animation and than render into it. This prevents animation on initial render

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants