This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animator): skip animation for initial show/hide #2331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngShow/ngHide directivies started animation just after rendering causing unexpected behaviour of showing animation of elements that should be already shown. This fix allows specifing "instant" parameter for $animator.show and $animator.hide functions to skip actual animation. More information is at angular#2309
|
+1 |
|
Thanks for the commit. We have already fixed this issue in a cleaner way. |
|
Hi, is the fix commited yet? The issue is still showing up after merging with the latest version of $animator. |
|
This is already checked into the master branch.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngShow/ngHide directivies started animation just after rendering causing
unexpected behaviour of showing animation of elements that should be already
shown. This fix allows specifing "instant" parameter for $animator.show and
$animator.hide functions to skip actual animation.
More information is at #2309