This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngModel): handle interpolated names for ngModel #2426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix that controls with interpolated names don't publish themselves to the form, cause the name isn't known at publishing time. Refers angular#1404
|
Doesn't work with latest changes. |
Pasvaz
added a commit
to Pasvaz/angular.js
that referenced
this pull request
Jun 17, 2013
ngName allows forms' fields to set their name dynamically, especially useful with ngRepeat.
Right now is not possible to validate form controls like this: <input type="text" name="{{field.name}}" ng-model="field.data">
The current work-around is to use one nested form for each field but indeed it's an hack rather than a solution.
This implementation could be moved inside the directive 'ngModel' or within its own directive 'ngName', I left intentionally it in the NgModelController because it's slightly faster, however I can refactor it as you prefer.
this fixes also the issues angular#1404 and angular#2426
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that controls with interpolated names don't publish
themselves to the form, cause the name isn't known at
publishing time.
Refers #1404